Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(connect): df.dtypes #3377

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(connect): df.dtypes #3377

wants to merge 1 commit into from

Conversation

andrewgazelka
Copy link
Member

No description provided.

Copy link
Member Author

andrewgazelka commented Nov 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from da9ae04 to 2d48b32 Compare November 21, 2024 01:45
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from 2d48b32 to 9711e2c Compare November 21, 2024 01:50
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from 9711e2c to 73c5c9b Compare November 21, 2024 03:22
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from 73c5c9b to c026db1 Compare November 21, 2024 04:19
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from c026db1 to e4dadeb Compare November 21, 2024 05:17
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from e4dadeb to 9bcb827 Compare November 21, 2024 05:18
@andrewgazelka andrewgazelka force-pushed the andrew/connect-dtypes branch 2 times, most recently from cee83ec to 5ccfa9f Compare November 21, 2024 05:19
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from 9bcb827 to 886d014 Compare November 21, 2024 16:57
@andrewgazelka andrewgazelka mentioned this pull request Nov 21, 2024
1 task
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from 886d014 to 14d1d50 Compare November 21, 2024 18:43
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch 2 times, most recently from 7302bfb to 62ae066 Compare December 4, 2024 02:09
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from 62ae066 to 6e58760 Compare December 4, 2024 02:35
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from 6f43372 to 8efe7d7 Compare December 5, 2024 21:53
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from 8efe7d7 to b7848ce Compare December 9, 2024 22:09
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from b7848ce to 0de7b03 Compare December 10, 2024 01:51
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from 0de7b03 to 3cb7252 Compare December 10, 2024 06:24
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from 3cb7252 to 21fc2ec Compare December 10, 2024 23:53
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from 21fc2ec to f2a1799 Compare December 11, 2024 21:04
@andrewgazelka andrewgazelka force-pushed the andrew/connect-intersect-union branch from f2a1799 to 11fefd5 Compare December 11, 2024 21:06
@andrewgazelka andrewgazelka force-pushed the andrew/connect-dtypes branch 2 times, most recently from 7c05508 to 871802f Compare December 11, 2024 21:12
@andrewgazelka andrewgazelka changed the base branch from andrew/connect-intersect-union to main December 11, 2024 21:12
@andrewgazelka andrewgazelka changed the title [TEST] connect: df.dtypes test(connect): df.dtypes Dec 11, 2024
@andrewgazelka andrewgazelka marked this pull request as ready for review December 11, 2024 21:19
@github-actions github-actions bot added the test label Dec 11, 2024
Copy link

codspeed-hq bot commented Dec 11, 2024

CodSpeed Performance Report

Merging #3377 will degrade performances by 13.41%

Comparing andrew/connect-dtypes (35acf42) with main (ae74c10)

Summary

❌ 1 regressions
✅ 26 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main andrew/connect-dtypes Change
test_iter_rows_first_row[100 Small Files] 131.6 ms 152 ms -13.41%

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.84%. Comparing base (ae74c10) to head (35acf42).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3377   +/-   ##
=======================================
  Coverage   77.84%   77.84%           
=======================================
  Files         718      718           
  Lines       88250    88252    +2     
=======================================
+ Hits        68696    68702    +6     
+ Misses      19554    19550    -4     

see 3 files with indirect coverage changes

@andrewgazelka andrewgazelka force-pushed the andrew/connect-dtypes branch 6 times, most recently from 5ac7695 to f70617f Compare December 19, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant